Welcome to the 44th edition of Git Rev News, a digest of all things Git. For our goals, the archives, the way we work, and how to contribute or to subscribe, see the Git Rev News page on git.github.io.
This edition covers what happened during the month of September 2018.
Brian Carlson sent a patch that adds a
.editorconfig file to the
The goal of adding this file to the Git codebase is to make it easier to automatically configure one’s editor. This will help contributors, especially new ones, follow the many indentation rules used in the Git codebase without having to read the CodingGuidelines document.
Taylor Blau, who has been using Vim with the editorconfig-vim plugin
for years, supported the patch and the choice of settings that Brian
had written in the
.editorconfig file. He suggested adding a
guideline to enforce at most 72 characters per line in commit
Junio Hamano, the Git maintainer, also replied to Brian wondering how
to keep the content of the file in sync with the
that is already part of the project and can be used through the
style Makefile target.
Brian replied to Junio that
make style is not run automatically and
only formats C code, not Perl, Python, shell code and commit
messages. Brian also said that he had trouble running
make style as
clang-format as a Git subcommand.
Junio replied that in an ideal dream-world, an EditorConfig driven tool solution to “generate clang-format configuration from the section for C language in any EditorConfig file” already existed, but otherwise he would be “perfectly OK if the plan is to manually keep them (loosely) in sync”.
Eric Sunshine then pointed Brian to git-clang-format
clang-format with Git, so that clang-format can be
run on the changes in current files or a specific commit.
This prompted Peff and Brian to discuss possible improvements in
Debian or Git that would make
git-clang-format work better.
Responding to Junio, Brian suggested adding a script to check that
.clang-format were kept in sync, but Junio
replied that adding a comment in both files saying that they should be
kept in sync would be enough.
Brian resent an improved version of his patch which enforces at most 72 characters per line in commit messages along with another patch that adds the comments that Junio suggested.
Ævar Arnfjörð Bjarmason suggested an improvement to also catch Perl
files with the
.pm file extensions. Brian
implemented this in a third version
of his patches.
This third version should be merged into the “master” branch soon.
Git tools and sites
This edition of Git Rev News was curated by Christian Couder <email@example.com>, Jakub Narębski <firstname.lastname@example.org>, Markus Jansen <email@example.com> and Gabriel Alcaras <firstname.lastname@example.org>.